Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: return right response code when http_to_https enabled in redirect plugin. #2311

Merged
merged 6 commits into from
Sep 27, 2020
Merged

bugfix: return right response code when http_to_https enabled in redirect plugin. #2311

merged 6 commits into from
Sep 27, 2020

Conversation

gy09535
Copy link
Contributor

@gy09535 gy09535 commented Sep 25, 2020 •
edited
Loading

What this PR does / why we need it:

fix: #2257

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

@gy09535 gy09535 changed the title fix: https://github.com/apache/apisix/issues/2257 fix: redirect is not correct Sep 25, 2020
@moonming moonming mentioned this pull request Sep 25, 2020
Closed
4 tasks
@gy09535
Update redirect.lua
2aedcb8 
change judge method
@gy09535
Copy link
Contributor Author

gy09535 commented Sep 25, 2020

If have times, please help review another PR, #2177 @spacewander @liuhengloveyou

@moonming moonming added this to the 2.0 milestone Sep 26, 2020
@moonming moonming changed the title fix: redirect is not correct bugfix: return right response code when http_to_https enabled in redirect plugin. Sep 27, 2020
@moonming moonming merged commit ce6dc64 into apache:master Sep 27, 2020
@gy09535 gy09535 deleted the bugfix/http-redirect-301 branch September 27, 2020 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuhengloveyou liuhengloveyou liuhengloveyou left review comments

@moonming moonming moonming approved these changes

@membphis membphis membphis approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

bug: http_to_https ret_code 307 not working
5 participants
@gy09535 @spacewander @liuhengloveyou @membphis @moonming